Skip to content

feat: Inactive group headers for GroupMultiSelectPrompt#199

Open
AdrianGonz97 wants to merge 6 commits intobombshell-dev:mainfrom
AdrianGonz97:feat/inactive-group-headers
Open

feat: Inactive group headers for GroupMultiSelectPrompt#199
AdrianGonz97 wants to merge 6 commits intobombshell-dev:mainfrom
AdrianGonz97:feat/inactive-group-headers

Conversation

@AdrianGonz97
Copy link

@AdrianGonz97 AdrianGonz97 commented Jun 20, 2024 •
edited
Loading

Closes #197

By default, group headers are selectable, allowing you to quickly select all of the options within that group. Setting the new option, selectableGroups, to false will disable them, making the group headers inactive.

the following code snippet:

import { groupMultiselect } from "@clack/prompts";

await groupMultiselect({
	message: "Which libraries would you like to setup?",
	selectableGroups: false,
	cursorAt: "Bootstrap",
	options: {
		CSS: [
			{ label: "Bootstrap", value: "Bootstrap" },
			{ label: "TailwindCSS", value: "TailwindCSS" },
			{ label: "UnoCSS", value: "UnoCSS" },
			{ label: "Bulma", value: "Bulma" },
		],
		Testing: [
			{ label: "Playwright", value: "Playwright" },
			{ label: "Vitest", value: "Vitest" },
		],
		Database: [
			{ label: "Drizzle", value: "Drizzle" },
			{ label: "Prisma", value: "Prisma" },
		],
		Auth: [
			{ label: "Lucia", value: "Lucia" },
			{ label: "Auth.js", value: "Auth.js" },
		],
	},
});

will now produce this prompt:
img

Vertical spacing can also be adjusted with a spacedGroups option as well:
img

@AdrianGonz97 AdrianGonz97 mentioned this pull request Jun 20, 2024
Merged
benmccann
benmccann reviewed Jun 20, 2024
View reviewed changes
@orochaa
Copy link
Contributor

orochaa commented Jul 3, 2024

Hey @AdrianGonz97, great work!

I just wanted to point out that the first group shouldn't have an empty line before it. In my opinion, this option should only add empty lines between the groups, not before or after. It looks a bit odd compared to the other prompts.

@benmccann
Copy link

benmccann commented Nov 20, 2024

Personally I think it would look weird to put a space before all items except the first one.

We ended up not using this (#197 (comment)), but feel free to merge it still if you think folks would find it useful. We do have some other changes though that we had to fork the library for and could merge those back if this library picks up again.

@natemoo-re
Copy link
Member

natemoo-re commented Dec 14, 2024

Hey @benmccann, thanks for the update! I am picking up steam again here and would love to get changes merged back upstream! 🧡

I agree that the changes in this PR are great to have in general tho! Will likely merge for those who want it.

@natemoo-re natemoo-re mentioned this pull request Dec 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@benmccann benmccann benmccann left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Request] header component or multiselect with multiple groups

4 participants

@AdrianGonz97 @orochaa @benmccann @natemoo-re